Submitted by koxuan
https://github.com/code-423n4/2023-01-popcorn/blob/main/src/vault/Vault.sol#L409-L411 
https://github.com/code-423n4/2023-01-popcorn/blob/main/src/vault/Vault.sol#L211-L244 
https://github.com/code-423n4/2023-01-popcorn/blob/main/src/vault/Vault.sol#L398-L416
ERC4626 standard requires maxWithdraw to return the maximum amount of underlying assets that can be withdrawn from the owner balance with a single withdraw call. withdraw in Vault implements a fee which is not calculated in maxWithdraw in Vault. Therefore, upstream contracts that call maxWithdraw and use the return value for withdraw will always revert.
Upstream contract calls maxWithdraw to determine maximum amount of assets user can withdraw. adapter is the wrapper that allows interaction with the underlying ERC4626 protocol.
The upstream contract uses the return amount of assets as the input for withdraw. Notice that there is a withdrawal fee added by increasing the shares required. Since maxWithdraw would have returned the maximum assets that can be returned, increasing the shares required from withdrawal fee will mean that the shares required will exceed shares that user have. This will cause a revert during the transfer of shares from user to vault.
Note, this applies to all max* functions too in Vault. They all delegate to adapter which does not include withdrawal or deposit fee.
Recommend calculating the withdrawal fee and deducting it in maxWithdraw. Same for the withdrawal and deposit fees for all the max* functions.
RedVeil (Popcorn) acknowledged 
For this audit, 97 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by IllIllI received the top score from the judge.
The following wardens also submitted reports: ulqiorra,
DevTimSch,
luxartvinsec,
Deathstore,
immeas,
yongskiws,
JDeryl,
halden,
rbserver,
Udsen,
apvlki,
Breeje,
ddimitrov22,
0xBeirao,
nadin,
hansfriese,
Deekshith99,
Awesome,
sayan,
tsvetanovv,
eccentricexit,
cryptonue,
lukris02,
mrpathfindr,
0xAgro,
descharre,
Aymen0909,
Kaiziron,
ethernomad,
SleepingBugs,
DevABDee,
doublesharp,
Walter,
aashar,
Mukund,
tnevler,
merlin,
dharma09,
codetilda,
matrix_0wl,
0xWeiss,
Bnke0x0,
ast3ros,
0xMirce,
Kaysoft,
H0,
csanuragjain,
Guild_3,
fs0c,
shark,
Rickard,
waldenyan20,
Ermaniwe,
SkyWalkerMan,
Kenshin,
cryptostellar5,
y1cunhui,
0xRobocop,
simon135,
DadeKuma,
RaymondFam,
0xSmartContract,
savi0ur,
Sathish9098,
Diana,
Dewaxindo,
IceBear,
0x3b,
0xNineDec,
adeolu,
2997ms,
Cryptor,
pavankv,
Inspectah,
Ruhum,
mookimgo,
scokaf,
0xTraub,
chaduke,
chrisdior4,
Rolezn,
georgits,
yosuke,
btk,
ustas,
chandkommanaboyina,
Praise,
Bauer,
hashminer0725,
UdarTeam,
rebase,
41i3xn,
seeu,
arialblack14,
climber2002, and
olegthegoat.
