Submitted by cccz, also found by bin2chen
The strategy contract will generally let the Adapter contract use delegatecall to call its functions.
So IAdapter(address(this)).call is used frequently in strategy contracts, because when the Adapter calls the strategys functions using delegatecall, address(this) is the Adapter:
But in AdapterBase._verifyAndSetupStrategy, the verifyAdapterSelectorCompatibility/verifyAdapterCompatibility/setUp functions are not called with delegatecall, which causes the context of these functions to be the strategy contract:
And since the strategy contract does not implement the interface of the Adapter contract, these functions will fail, making it impossible to create a Vault using that strategy.
More dangerously, if functions such as setup are executed successfully because they do not call the Adapters functions, they may later error out when calling the harvest function because the settings in setup are invalid.
https://github.com/code-423n4/2023-01-popcorn/blob/d95fc31449c260901811196d617366d6352258cd/src/vault/adapter/abstracts/AdapterBase.sol#L479-L483
In AdapterBase.\_verifyAndSetupStrategy, the verifyAdapterSelectorCompatibility/verifyAdapterCompatibility/setUp functions are called using delegatecall.
RedVeil (Popcorn) confirmed 
