Submitted by 0xNazgul
Currently in Vault.sol there are four different fee types:
There is a proper check to make sure that individually none of them are >= 1e18. However, they can total to more than 1e18 and cause unsuspecting users to pay more than they may want to.
Just taking the deposit and withdrawal fees into account say both of them are set to 5e17, totaling to 1e18. If a user were to then deposit and withdraw, that would be 100%. Add in the other two fees and this situation gets even worse.
Consider making sure that the total of all four fee types is less than 1e18 instead of individually.
RedVeil (Popcorn) acknowledged 
