Submitted by eierina, also found by doublesharp
https://github.com/code-423n4/2023-01-popcorn/blob/dcdd3ceda3d5bd87105e691ebc054fb8b04ae583/src/vault/adapter/abstracts/AdapterBase.sol#L444-L446 
https://github.com/code-423n4/2023-01-popcorn/blob/dcdd3ceda3d5bd87105e691ebc054fb8b04ae583/src/vault/adapter/abstracts/AdapterBase.sol#L55-L62 
https://github.com/code-423n4/2023-01-popcorn/blob/36477d96788791ff07a1ba40d0c726fb39bf05ec/src/vault/adapter/beefy/BeefyAdapter.sol#L20-L55
https://github.com/code-423n4/2023-01-popcorn/blob/36477d96788791ff07a1ba40d0c726fb39bf05ec/src/vault/adapter/yearn/YearnAdapter.sol#L17-L43
AdapterBase based adapters instances like BeefyAdapter, and YearnAdapter can be rendered inoperable and halt the project.
When using upgradeable smart contracts, all interactions occur with the contract instance, not the underlying logic contract.
A malicious actor sending transactions directly to the logic contract  does not pose a significant threat because changes made to the state of the logic contract will not affect the contract instance as the logic contracts storage is never utilized.
However, there is an exception to this rule. If a direct call to the logic contract results in a self-destruct operation, the logic contract will be eliminated, and all instances of your contract will delegate calls to a code-less address rendering all contract instances in the project inoperable.
Similarly, if the logic contract contains a delegatecall operation and is made to delegate a call to a malicious contract with a self-destruct function, the calling contract will also be destroyed.
The AdapterBase contract has an internal initializer function _AdapterBaseinit that among the other things, allows to assign the strategy address (see line 62, and line 79).
AdapterBase excerpt:
The function harvest does a delegatecall to the address defined by strategy:
An attacker can call the initializer method of the BeefyAdapter / YearnAdapter to pass a malicious contract to initialize the strategy address of AdapterBase, where the malicious contract only has a harvest() function or a fallback function that calls selfdestruct.
The attacker will then call harvest on BeefyAdapter / YearnAdapter implementation causing the logic contracts to be destroyed.
YearnAdapter excerpt:
BeefyAdapter excerpt:
Add constructors and use OZ Initializables \_disableInitializers() function as the only line of code in the constructor.
Also suggest the same for MultiRewardStaking and Vault contracts.
RedVeil (Popcorn) disputed
LSDan (judge) marked as invalid
eierina (warden) commented:
eierina (warden) commented:
LSDan (judge) decreased severity to Medium
