Submitted by fs0c, also found by obront and Lotus
In _paymentAH function from LienToken.sol, the stack argument should be storage instead of memory. This bug was also disclosed in the Spearbit audit of this program and was resolved during here: https://github.com/AstariaXYZ/astaria-core/pull/201/commits/5a0a86837c0dcf2f6768e8a42aa4215666b57f11, but was later re-introduced https://github.com/AstariaXYZ/astaria-core/commit/be9a14d08caafe125c44f6876ebb4f28f06d83d4 here. Marking it as high-severity as it was marked as same in the audit.
The position here is not deleted after the debt is paid as it is a memory pointer.
The first fix can be used again and it would work.
androolloyd (Astaria) commented:
SantiagoGregory (Astaria) acknowledged
Picodes (judge) decreased severity to Medium and commented:
androolloyd (Astaria) commented:
