Submitted by obront
As pointed out in the Spearbit audit:
This can cause a problem because processEpoch() cannot be called when there are open liens, and liens may remain open in the event that a lien expires and isnt promptly liquidated.
processEpoch() contains the following check to ensure that all liens are closed before the epoch is processed:
The accounting considers a lien open (via s.epochData[s.currentEpoch].liensOpenForEpoch) unless this value is decremented, which happens in three cases: when (a) the full payment is made, (b) the lien is bought out, or (c) the lien is liquidated.
In the event that a lien expires and nobody calls liquidate() (for example, if the NFT seems worthless and no other user wants to pay the gas to execute the function for the fee), this would cause processEpoch() to fail, and could create delays in the epoch processing and cause the accounting issues pointed out in the previous audit.
Astaria should implement a monitoring solution to ensure that liquidate() is always called promptly for expired liens, and that processEpoch() is always called promptly when the epoch ends.
SantiagoGregory (Astaria) acknowledged and commented:
