Submitted by Ruhum
https://github.com/code-423n4/2023-01-astaria/blob/main/src/VaultImplementation.sol#L229-L266
https://github.com/code-423n4/2023-01-astaria/blob/main/src/AstariaRouter.sol#L439
The vault doesnt verify that a deadline hasnt passed when a commitment is validated. Users are able to take out loans using strategies that have already expired. Depending on the nature of the strategy that can cause a loss of funds for the LPs.
When you take out a loan using the AstariaRouter, the deadline is verified:
But, VaultImplementation._validateCommitment() skips that check:
If you search for deadline in the codebase youll see that theres no other place where the property is accessed.
As long as the user takes out the loan from the vault directly, they can use strategies that have expired. The vault owner could prevent this from happening by incrementing the strategistNonce after the strategy expired.
In VaultImplementation._validateCommitment() check that deadline > block.timestamp.
SantiagoGregory (Astaria) confirmed
