Submitted by IllIllI, also found by gzeon
Not all IERC20 implementations revert() when theres a failure in approve(). If one of these tokens returns false, there is no check for whether this has happened during the order listing validation, so it will only be detected when the order is attempted.
If the approval failure isnt detected, the listing will never be fillable, because the funds wont be able to be pulled from the opensea conduit. Once this happens, and if its detected, the only way to fix it is to create a counter-listing at a lower price (which may be below the market value of the tokens), waiting for the order to expire (which it may never), or by buying out all of the Rae to cancel the order (very expensive and defeats the purpose of pooling funds in the first place).
The return value of approve() isnt checked, so the order will be allowed to be listed without having approved the conduit:
https://github.com/code-423n4/2022-12-tessera/blob/f37a11407da2af844bbfe868e1422e3665a5f8e4/src/seaport/targets/SeaportLister.sol#L29-L46
Use OpenZeppelins safeApprove(), which checks the return code and reverts if its not success.
mehtaculous (Tessera) disputed and commented:
HickupHH3 (judge) commented:
stevennevins (Tessera) acknowledged
