Submitted by AkshaySrivastav, also found by ladboy233, hihen, and csanuragjain
EthereumToOptimismExecutor.sol#L45-L59
EthereumToArbitrumExecutor.sol#L31-L45
The CrossChainExecutorArbitrum and CrossChainExecutorOptimism contracts both use CallLib library to invoke Calls on external contract. As per the CallLib library implementation, any failing Call results in the entire transaction getting reverted.
The CrossChainExecutor contracts does not store whether the calls in CallLib.Call[] were already attempted which failed.
This creates several issues for CrossChainExecutor contracts.
PoCs for the above issues are listed below.
The CrossChainExecutor contract should store whether a relayed call was attempted to be executed to make sure the execution cannot be tried again.
The CallLib library can be changed to not completely revert the transaction when any individual Call gets failed.
Alex the Entreprenerd (judge) commented:
PierrickGT (PoolTogether) confirmed, but disagreed with severity and commented:
Alex the Entreprenerd (judge) commented:
Alex the Entreprenerd (judge) commented:
Alex the Entreprenerd (judge) decreased severity to Medium and commented:
For this contest, 4 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by 0xSmartContract received the top score from the judge.
The following wardens also submitted reports: cryptonue, ladboy233, and gzeon.
