Submitted by ak1, also found by sces60107
When the contract is paused , allowing startRewardsCycle would inflate the token value which might not be safe.
Rewards should not be claimed by anyone when all other operations are paused.
I saw that the witdrawGGP has this WhenNotPaused modifier.
Inflate should not consider the paused duration.
Lets say, when the contract is paused for the duration of 2 months, then the dao, protocol, and node validator would enjoy the rewards. This is not good for a healthy protocol.
startRewardsCycle does not have the WhenNotPaused modifier.
We suggest to use WhenNotPaused modifier.
emersoncloud (GoGoPool) confirmed
Alex the Entreprenerd (judge) commented:
emersoncloud (GoGoPool) mitigated:
Status: Mitigation confirmed with comments. Full details in report from RaymondFam.
