Submitted by cccz, also found by hansfriese
The first eight digits of the RuniverseLand TokenID indicate the corresponding plotSize of the NFT.
Owner can call RuniverseLandMinter.ownerMintUsingTokenId directly to mint the NFT for a specific TokenID.
In RuniverseLandMinter._mintTokensUsingTokenId, there is no verification that the first eight bits of the tokenId match the plotSize parameter, which allows the owner to bypass the plotsAvailablePerSize limit.
For example, the plotSize parameter provided by the owner when calling ownerMintUsingTokenId is 8 * 8, while the plotSize contained in the tokenId is 128 * 128, thus bypassing the plotsAvailablePerSize limit.
Also, once RuniverseLands with mismatched tokenId and plotSize are minted, the supply of RuniverseLands with different plotSize will no longer be correct because the plotsMinted variable is incorrectly calculated.
contracts/RuniverseLandMinter.sol#L362-L393
Consider verifying in RuniverseLandMinter._mintTokensUsingTokenId that the first eight bits of the tokenId match the plotSize parameter.
Alex the Entreprenerd (judge) commented:
msclecram (Forgotten Runiverse) confirmed
Alex the Entreprenerd (judge) commented:
msclecram (Forgotten Runiverse) commented:
