Submitted by Trust
https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/GiantMevAndFeesPool.sol#L105
batchRotateLPTokens in GiantMevAndFeesPool allows any user to rotate LP tokens of stakingFundsVaults around.
There is a check that sender has over 0.5 ether of lpTokenETH, to prevent griefing. However, this check is unsatisfactory as user can at any stage deposit ETH to receive lpTokenETH and burn it to receive back ETH. Their lpTokenETH holdings do not correlate with their interest in the vault funds.
Therefore, malicious users can keep bouncing LP tokens around and prevent them from being available for actual staking by liquid staking manager.
Giant pools are prone to user griefing, preventing their holdings from being staked.
Three options:
vince0656 (Stakehouse) disputed and commented:
