Submitted by Trust
https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/StakingFundsVault.sol#L224
StakingFundsVault has the claimRewards() function to allow users to withdraw profits.
The issue is that updateAccumulatedETHPerLP() is not guaranteed to be called, which means the ETH reward distribution in _distribute would use stale value, and users will not receive as many rewards as they should.
updateAccumulatedETHPerLP is only called if the first BLS public key is part of the syndicate. However, for the other keys it makes no reason not to use the up to date accumulatedETHPerLPShare value.
User receives less rewards than they are eligible for if first passed BLS key is inactive.
Call updateAccumulatedETHPerLP() at the start of the function.
vince0656 (Stakehouse) confirmed and commented:
LSDan (judge) commented:
Trust (warden) commented:
