Submitted by Soosh
Config.sol#L47
The BLOCK_PERIOD is set to 13 seconds in Config.sol.
Since moving to Proof-of-Stake (PoS) after the Merge, block times on ethereum are fixed at 12 seconds per block (slots).
https://ethereum.org/en/developers/docs/consensus-mechanisms/pos/#:~:text=Whereas%20under%20proof%2Dof%2Dwork,block%20proposer%20in%20every%20slot.
This results in incorrect calculation of PRIORITY_EXPIRATION which is used to determine when a transaction in the Priority Queue should be considered expired.
The time difference can be calulated
By using block time of 13 seconds, a transaction in the Priority Queue incorrectly expires 5.5 hours earlier than is expected.
5.5 hours is a significant amount of time difference so I believe this issue to be Medium severity.
Change the block period to be 12 seconds
miladpiri (zkSync) confirmed and commented:
Alex the Entreprenerd (judge) commented:
For this contest, 13 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by HE1M received the top score from the judge.
The following wardens also submitted reports: brgltd, rbserver, pashov, ladboy233, 0xSmartContract, datapunk, cccz, ctf_sec, Tomo, Rolezn, jayjonah8, and chaduke.
