Submitted by 0x52
PA1D.sol#L665-L675
bidShares returned are incorrect leading to incorrect royalties.
Zora Market
Above you can see the Zora market lines that validate bidShares, which shows that Zora market bidShare.values should be percentages written out to 18 decimals. However PA1D#bidSharesForToken sets the bidShares.creator.value to the raw basis points set by the owner, which is many order of magnitudes different than expected.
To return the proper value, basis points returned need to be adjusted. Convert from basis points to percentage by dividing by 10 ** 2 (100) then scale to 18 decimals. The final result it to multiple the basis point by 10 ** (18 - 2) or 10 ** 16:
alexanderattar (Holograph) commented:
alexanderattar (Holograph) linked a PR:
