Submitted by Jeiwan, also found by __141345__ and m9800
A source contract can burn and transfer NFTs of users without their permission.
Every Holographed ERC721 collection is paired with a source contract, which is the user created contract thats extended by the Holographed ERC721 contract (HolographFactory.sol#L234-L246). A source contract, however, has excessive privileges in the Holographed ERC721. Specifically, it can burn and transfer users NFTs without their approval (HolographERC721.sol#L500, HolographERC721.sol#L577):
While this might be desirable for extensibility and flexibility, this puts users at the risk of being robbed by the source contract owner or a hacker who hacked the source contract owners key.
Consider removing the sourceBurn and sourceTransfer functions of HolographERC721 and requiring user approval to transfer or burn their tokens (burn and safeTransferFrom can be called by a source contract instead of sourceBurn and sourceTransfer).
gzeon (judge) decreased severity to Medium and commented:
alexanderattar (Holograph) confirmed and commented:
alexanderattar (Holograph) resolved:
