Submitted by Trust
HolographERC20.sol#L539
HolographERC20 is the ERC20 enforcer for Holograph. In  the safeTransferFrom operation, it calls _checkOnERC20Received:
The checkOnERC20Received function:
In essence, if the target is a contract, the enforcer requires it to fully implement EIP-4524. The problem is that this EIP is just a draft proposal, which the project cannot assume to be supported by any receiver contract, and definitely not every receiver contract.
The specs warn us:
Therefore, it is a very dangerous requirement to add in an ERC20 enforcer, and must be left to the implementation to do if it so desires.
ERC20s enforced by HolographERC20 are completely uncomposable. They cannot be used for almost any DeFi application, making it basically useless.
Remove the EIP-4524 requirements altogether.
gzeon (judge) commented:
alexanderattar (Holograph) confirmed and commented:
Trust (warden) commented:
ACC01ADE (Holograph) linked a PR:
