Submitted by d3e4, also found by __141345__, 2997ms, ballx, Bnke0x0, brgltd, brgltd, cccz, cccz, chaduke, d3e4, Dinesh11G, Jeiwan, joestakey, Lambda, martin, pashov, RedOneN, Trust, V_B, and vv7
PA1D.sol#L317
PA1D.sol#L340
Payout is blocked and tokens are stuck in contract.
PA1D._payoutToken() and PA1D._payoutTokens() call ERC20.transfer() in a require-statement to send tokens to a list of payout recipients.
Some tokens do not return a bool (e.g. USDT, BNB, OMG) on ERC20 methods. But since the require-statement expects a bool, for such a token a void return will also cause a revert, despite an otherwise successful transfer. That is, the token payout will always revert for such tokens.
Use OpenZeppelins SafeERC20, which handles the return value check as well as non-standard-compliant tokens.
alexanderattar (Holograph) commented:
alexanderattar (Holograph) linked a PR:
