Submitted by Chom, also found by 0x52, 0xA5DF, adriro, and ladboy233
HolographOperator.sol#L329
HolographOperator.sol#L419-L429
First, it will delete _operatorJobs[hash]; to have it not replayable.
Next, assume nonRevertingBridgeCall failed. NFT wont be minted and the catch block is entered.
_failedJobs[hash] is set to true and event is emitted
Notice that _operatorJobs[hash] has been deleted, so this job is not replayable. This mean NFT is lost forever since we cant retry executeJob.
Move delete _operatorJobs[hash]; to the end of function executeJob covered in if (!_failedJobs[hash])
But this implementation is not safe. The selected operator may get slashed. Additionally, you may need to check _failedJobs flag to allow retry for only the selected operator.
gzeon (judge) commented:
Trust (warden) commented:
alexanderattar (Holograph) commented:
gzeon (judge) increased severity to High and commented:
alexanderattar (Holograph) resolved and commented:
