Submitted by yixxas
https://github.com/code-423n4/2022-09-y2k-finance/blob/2175c044af98509261e4147edeb48e1036773771/src/Vault.sol#L295
https://github.com/code-423n4/2022-09-y2k-finance/blob/2175c044af98509261e4147edeb48e1036773771/src/Vault.sol#L360-L366
Admin can rug all user funds in every vault deployed by changing the controller address.
Controller can be changed by admin anytime without any warning to users.
Vault.sol#L295
Tokens in the vaults can then be called by the malicious contract to be transferred to their own address with sendTokens().
Vault.sol#L360-L366
Allow the change of controller address only in the VaultFactory(). This way, markets that have been created cannot have a different controller address, so users can be made aware of the change before choosing to make deposit of assets.
MiguelBits (Y2K Finance) marked as duplicate and commented:
HickupHH3 (judge) decreased severity to QA and commented:
yixxas (warden) commented:
HickupHH3 (judge) increased severity to Medium and commented:
For this contest, 59 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by Respx received the top score from the judge.
The following wardens also submitted reports: 0x1f8b, 0xc0ffEE, 0xDecorativePineapple, 0xmuxyz, 0xNazgul, 0xPanas, 0xSmartContract, ajtra, ak1, async, auditor0517, Aymen0909, Bahurum, Bnke0x0, brgltd, c3phas, carrotsmuggler, cccz, CodingNameKiki, csanuragjain, datapunk, Deivitto, djxploit, durianSausage, eierina, erictee, gogo, imare, Jeiwan, joestakey, jonatascm, kv, ladboy233, Lambda, leosathya, lukris02, oyc_109, pashov, pauliax, Picodes, PwnPatrol, R2, RaymondFam, rbserver, robee, rokinot, Rolezn, Ruhum, rvierdiiev, Saintcode_, scaraven, simon135, SooYa, Tointer, unforgiven, V_B, wagmi, and zzzitron.
