Submitted by CertoraInc, also found by 0xhunter, datapunk, dipp, Lambda, and wuwe1
VTVLVesting.sol#L446-L451
Two address tokens exist in the blockchain. For example, Synthetixs ProxyERC20 contract is such a token which exists in many forms (sUSD, sBTC). Tokens as such can be vested, but the admin can withdraw them even if they are vested by providing the other address to the withdrawOtherToken function. The only check in this function is that _otherTokenAddress != tokenAddress, which is irrelevant in the case of two address tokens.
This can make the admin be able to withdraw the vested funds and break the system, because the balance of the contract can be less than the vested amount.
Replace the address check with a balance check - record the vesting token balance of the contract before and after the transfer and assert that they are equal.
0xean (judge) decreased severity to Medium and commented:
lawrencehui (VTVL) acknowledged and commented:
