Submitted by TomJ, also found by ayeslick, csanuragjain, and pashov
VTVLVesting.sol#L245-L304
There is no check whether _startTimestamp and _endTimestamp is greater than block.timestamp
at VTVLVesting.sol _createClaimUnchecked function. Therefore it is possible for administrators to accidentally create
vesting schedule that starts and ends in the past without noticing it. When administrators does this and this transaction goes
through, then the vesting recipients can withdraw their entire vest amount which is not what administrators intended to do.
Add require check that force _startTimestamp to be greater than block.timestamp.
Team comments as below on line 260
However this is not an issue by adding require(_startTimestamp > uint40(block.timestamp)) since this will revert
transaction if _startTimestamp is less than block.timestamp so administrators can simply try again with correct time.
On the other hand, it is more dangerous to not include this check because transaction will simply succeed even though
_startTimestamp is set to past which means that there is a chance of administrators not noticing this.
Add following check in VTVLVesting.sol:_createClaimUnchecked function.
0xean (judge) commented:
lawrencehui (VTVL) acknowledged, but disagreed with severity and commented:
