Submitted by 0x52
Note: PartyDAO acknowledges that canceling an InProgress proposal (mid-step) can leave the governance party in a vulnerable or undesirable state because there is no cleanup logic run during a cancel in the Known Issues / Topics section of the contest readme. I still believe that this vulnerability needs to be mitigated as it can directly lead to loss of user funds.
Majority vote can abuse cancel functionality to steal an NFT owned by the party.
ArbitraryCallsProposal.sol implements the following safeguards for arbitrary proposals that are not unanimous:
Additionally ListOnOpenseaProposal.sol implements the following safeguards:
These safeguards are ultimately ineffective though. The majority could use the following steps to steal the NFT:
When a proposal is canceled, it should call a proposal specific function that makes sure everything is cleaned up. NFTs delisted, approvals revoked, etc.
merklejerk (PartyDAO) confirmed and commented:
HardlyDifficult (judge) commented:
0xble (PartyDAO) resolved:
