Submitted by scaraven
Governor.sol#L21
Ownable.sol#L63
Auction.sol#L22
governor.transferOwnership() and Auction.transferOwnership() is exposed to Treasury.sol and can be called in a governance proposal. If this is used then it causes an inconsistency between the owner of these contracts and settings.treasury which would prevent governance from ever modifying its own parameters and Ethereum from auctions will be sent to the wrong address.
I believe medium severity is suitable because we lose partial control of governance and/or ETH from auctions, assuming that a proposal (malicious or not) is passed which changes contract ownership.
The same issue applies to Auction.sol.
VS Code
Modify transferOwnership() in the relevant contracts so that if ownership is transferred, then settings.treasury is changed accordingly.
kulkarohan (Nouns Builder) acknowledged
Alex the Entreprenerd (judge) commented:
