Submitted by __141345__
When depositEther(), if 1 validators is used before, the whole deposit function will revert, causing DoS. depositEther() function will be inoperable until the gov manually removes the mistaken validator.
In depositEther(), if the pubKey is already used, the whole loop will revert, and the deposit operation cannot move on.
And in the next rewards cycle, lastRewardAmount will be linearly added to storedTotalAssets, their sum is the return value of totalAssets():
Temporarily the depositEther() function will be inaccessible. Until the governance calls the registry to pop the wrong validator.
Use try/catch to skip the wrong validator, then the deposit function will be more robust to unexpected situations.
FortisFortuna (Frax) commented:
0xean (judge) commented:
