Submitted by Critical
The Comptroller is expecting oracle.getUnderlyingPrice to return 0 for errors (Compound style returns, no revert). The current implementation will throw errors, resulting in the consumer of the oracle getting unexpected errors.
The Comptroller is expecting oracle.getUnderlyingPrice to return 0 for errors (Compound style returns, no revert).
However, the current implementation will revert when errored:
https://github.com/code-423n4/2022-09-canto/blob/65fbb8b9de22cf8f8f3d742b38b4be41ee35c468/src/Swap/BaseV1-periphery.sol#L549-L593
https://github.com/code-423n4/2022-09-canto/blob/65fbb8b9de22cf8f8f3d742b38b4be41ee35c468/src/Swap/BaseV1-core.sol#L271-L289
Consider using try catch and return 0 when errored.
nivasan1 (Canto) confirmed
