Submitted by zzykxx, also found by 8olidity, berndartmueller, bin2chen, bytehat, devtooligan, hansfriese, IllIllI, imare, Lambda, obront, philogy, shung, tonisives, zdhu, and zkhorse
It could become impossible to reveal gobblers which leads any new minted gobbler to have an emissionMultiple of 0 forever, preventing them from minting any goo.
In ArtGobblers.sol calling requestRandomSeed() sets gobblerRevealsData.waitingForSeed = true, which makes both revealGobblers() and upgradeRandProvider() revert.
The only way to set gobblerRevealsData.waitingForSeed = false is by calling acceptRandomSeed() which can only be called by the randProvider itself.
This means that if randProvider stops working and requestRandomSeed() is called (which sets gobblerRevealsData.waitingForSeed = true) there is no way for upgradeRandProvider() and revealGobblers() to be ever called again.
Copy the test in RandProvider.t.sol and run it with forge test -m testRandomnessBrick:
A potential fix is to reset some variables in upgradeRandProvider instead of reverting:
This gives a little extra powers to the owner, but I dont think its a big deal considering that he can just plug in any provider he wants anyway.
Alex the Entreprenerd (judge) commented:
FrankieIsLost (Art Gobblers) commented:
