Submitted by 0xA5DF, also found by Lambda and sseefried
HomeFi.sol#L156-L169
HomeFi.sol#L199-L208
In case where the admin wallet has been hacked, the attacker can drain all funds out of the project within minutes. All the attacker needs is the admin to sign a single meta/normal tx.
Even though the likelihood of the admin wallet being hacked might be low, given that the impact is critical - I think this makes it at least a medium bug.
Examples of cases where the attacker can gain access to admin wallet:
Since the forwarder has the power to do everything in the system , once an attacker manages to replace it with a malicious forwarder, he can do whatever he wants withing minutes:
Even when signatures are required, you can bypass it by using the approveHash function.
Heres a PoC for taking over and running the Project.setComplete() function (I havent included a whole process of changing SC etc. since that would be too time consuming, but there shouldnt be a difference between functions, all can be impersonated once you control the forwarder).
The PoC was added to projectTests.ts#L1109, and is based on the should be able to complete a task test.
parv3213 (Rigor) confirmed
0xA5DF (warden) commented:
Jack the Pug (judge) commented:
