Submitted by hansfriese
Project.sol#L402
The changeOrder() function will revert when its called for the tasks that dont have subcontractors.
As a result, the project builder and contractor cant change the cost of a task until the subcontractor is confirmed.
The changeOrder() is used to change the cost or subcontractor of a task and there is no documentation that this function must be called only after a subcontractor is confirmed.
Also, its reasonable to be able to change the cost when a subcontractor isnt confirmed yet.
But when it checks signature here, it assumes the task has a confirmed subcontractor already and checkSignatureTask() will revert in other cases.
So this function will be useless for non SCConfirmed tasks.
Solidity Visual Developer of VSCode
We should check separately in case the subcontractor is confirmed or not here.
parv3213 (Rigor) acknowledged
0xA5DF (warden) commented:
Jack the Pug (judge) decreased severity to Medium and commented:
