Submitted by 0x1f8b
https://github.com/code-423n4/2022-08-olympus/blob/b5e139d732eb4c07102f149fb9426d356af617aa/src/policies/Governance.sol#L167
https://github.com/code-423n4/2022-08-olympus/blob/b5e139d732eb4c07102f149fb9426d356af617aa/src/policies/Governance.sol#L66
It is possible to overwrite proposals in certain circumstances. The method Governance.submitProposal doesnt check if the proposalId (stored in a different contract) exists already as a valid proposal in getProposalMetadata.
If the project update the kernel module INSTR and reconfigure proposals and call INSTR.store(instructions_);, the counter may return a proposalId of an existing proposal and overwrite an existing previous one.
This is due to the fact that the proposals are saved in a mapping of a contract that is not related to the one that returns the counters, and furthermore, they do not check that the record already exists.
fullyallocated (Olympus) acknowledged, but disagreed with severity and commented:
0xean (judge) decreased severity to Medium and commented:
