Submitted by byndooa, also found by arcoun, cccz, Lambda, and thebensams
https://github.com/code-423n4/2022-08-mimo/blob/eb1a5016b69f72bc1e4fd3600a65e908bd228f13/contracts/proxy/MIMOProxyFactory.sol#L40-L58
https://github.com/code-423n4/2022-08-mimo/blob/eb1a5016b69f72bc1e4fd3600a65e908bd228f13/contracts/proxy/MIMOProxyRegistry.sol#L39-L59
The description of Registry.sol is following:
/// Deploys new proxies via the factory and keeps a registry of owners to proxies. Owners can only
/// have one proxy at a time.
But it is not.
There are multiple problems:
https://github.com/code-423n4/2022-08-mimo/blob/eb1a5016b69f72bc1e4fd3600a65e908bd228f13/contracts/proxy/MIMOProxyFactory.sol#L40-L58
https://github.com/code-423n4/2022-08-mimo/blob/eb1a5016b69f72bc1e4fd3600a65e908bd228f13/contracts/proxy/MIMOProxyRegistry.sol#L39-L59
Hardhat
Delete Proxy.transfetOwnership().
Disallow anyone to call deploy() and deployFor() in Factory().
RnkSngh (Mimo) confirmed and commented:
gzeoneth (judge) increased severity to High and commented:
m19 (Mimo) commented:
gzeoneth (judge) commented:
m19 (Mimo) commented:
horsefacts (warden) reviewed mitigation:
