Submitted by Lambda, also found by 0x52, KIntern_NA, and shenwilly
If one creator specified a share that is larger than BASIS_POINTS, the first creator gets all of the royalties. Depending on how these are set (which is not in the control of the project), this can be exploited by the first creator.
A collective of artists have implemented a process where everyone can set its own share of the fees to the value that he thinks is fair and these values are returned by getRoyalties. Bob, the first entry in the list of _recipients sets its value to a value that is slightly larger than BASIS_POINTS such that he gets all of the royalties.
There is no need for this check / logic, as the whole sum (totalShares) is used anyway to normalize the values.
HardlyDifficult (Foundation) acknowledged, but disagreed with severity and commented:
HickupHH3 (judge) commented:
