Submitted by JohnSmith, also found by ayeslick, reassor, rokinot, and scaraven
To block an address it must pass the isContract(address) check:
https://github.com/code-423n4/2022-08-fiatdao/blob/main/contracts/features/Blocklist.sol#L25
Which just checks code length at the address provided.
Attacker can interact with the system and selfdestruct his contract, and with help of CREATE2 recreate it at same address when he needs to interact with the system again.
Below is a simple example of salted contract creation, which you can test against _isContract(address) function.
One of the goals of Ethereum is for humans and smart contracts to both be treated equally. This leads into a future where smart contracts interact seamlessly with humans and other contracts. It might change in the future , but for now an arbitrary address is ambiguous.
We should consider blacklisting addresses without checking if they are contracts.
lacoop6tu (FIAT DAO) commented:
Justin Goro (judge) commented:
lacoop6tu (FIAT DAO) commented:
Justin Goro (judge) commented:
elnilz (FIAT DAO) acknowledged
IllIllI (warden) reviewed mitigation:
