Submitted by CertoraInc, also found by 0x1f8b, 0xSky, CodingNameKiki, DecorativePineapple, jonatascm, Noah3o6, oyc_109, pedr02b2, peritoflores, and Waze
https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/VotingEscrow.sol#L425-L428
https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/VotingEscrow.sol#L485-L488
https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/VotingEscrow.sol#L546
https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/VotingEscrow.sol#L657
https://github.com/code-423n4/2022-08-fiatdao/blob/fece3bdb79ccacb501099c24b60312cd0b2e4bb2/contracts/VotingEscrow.sol#L676
Some ERC20 tokens functions dont return a boolean, for example USDT, BNB, OMG. So the VotingEscrow contract simply wont work with tokens like that as the token.
The USDTs transfer and transferFrom functions doesnt return a bool, so the call to these functions will revert although the user has enough balance and the VotingEscrow contract wont work, assuming that token is USDT.
Manual auditing - VS Code, some hardhat tests and me :)
Use the OpenZepplins safeTransfer and safeTransferFrom functions.
lacoop6tu (FIAT DAO) disputed and commented:
Justin Goro (judge) commented:
elnilz (FIAT DAO) commented:
elnilz (FIAT DAO) commented:
Justin Goro (judge) commented:
IllIllI (warden) reviewed mitigation:
