Submitted by hansfriese, also found by panprog
https://github.com/code-423n4/2022-07-swivel/blob/fd36ce96b46943026cb2dfcb76dfa3f884f51c18/VaultTracker/VaultTracker.sol#L124
https://github.com/code-423n4/2022-07-swivel/blob/fd36ce96b46943026cb2dfcb76dfa3f884f51c18/VaultTracker/VaultTracker.sol#L132
With most functions in VaultTracker.sol, users can call them only once after maturity has been reached.
So from the second call of any functions after maturity, it will revert and users might lose their funds or interests.
The main problem is that `vlt.exchangeRate might be larger than maturityRate after maturity here.
Then it will revert from the second call with uint underflow here.
So such scenario is possible.
Solidity Visual Developer of VSCode
We should save vlt.exchangeRate = maturityRate when maturityRate > 0 and exchangeRate > maturityRate.
There are several places to modify for safety.
JTraversa (Swivel) disputed, disagreed with severity and commented:
robrobbins (Swivel) resolved:
0xean (judge) decreased severity to Medium and commented:
