Submitted by cccz, also found by 0x1f8b, 0xHarry, AuditsAreUS, djxploit, jayjonah8, joestakey, and teddav
The validateOrder function of GolomTrader calls the Solidity ecrecover function directly to verify the given signatures.
The return value of ecrecover may be 0, which means the signature is invalid, but the check can be bypassed when signer is 0.
https://github.com/code-423n4/2022-07-golom/blob/e5efa8f9d6dda92a90b8b2c4902320acf0c26816/contracts/core/GolomTrader.sol#L176-L177
Use the recover function from OpenZeppelins ECDSA library for signature verification.
kenzo (warden) commented:
0xsaruman (Golom) disputed
LSDan (judge) commented:
