Submitted by zzzitron, also found by 0x29A
HIGH - Assets can be compromised directly.
One can drain eth out from migration module to buyout module using custom made FERC1155 token.
The proof of concept shows a scenario where Alice is draining migration module using custom made FERC1155 token.
Note: For simplicity, the evil_token reenters for a fixed number of times. But one can adjust to drain all the eth in the migration module.
Note2: For now the eth is in the buyout module, but given the current implementation of buyout module, the same actor can drain eth from buyout.
The commit function is not written in Checks, Effects, Interactions (CEI) patterns.
Foundry
Follow Checks, Effects, Interactions patterns. One can also consider adding reentrancy guard.
stevennevins (Fractional) confirmed
HardlyDifficult (judge) commented:
