Submitted by panprog
NameWrapper.sol#L955-L961
There is a general incorrect logic of allowing to burn only PARENT_CANNOT_CONTROL fuse without burning CANNOT_UNWRAP fuse. If only PARENT_CANNOT_CONTROL fuse is burnt, then domain can be unwrapped by its owner and then wrapped again, which clears PARENT_CANNOT_CONTROL fuse, making it possible for parent to bypass the limitation of parent control before the expiry.
Bypassing parent control scenario:
Copy this to test/wrapper and run:
yarn test test/wrapper/NameWrapperBypassPCC.js
https://gist.github.com/panprog/71dea0fd1875b4d7d5849f7da822ea8b
Burning any fuse (including PARENT_CANNOT_CONTROL) must require CANNOT_UNWRAP fuse to be burned (because otherwise its possible to unwrap+wrap to clear that fuse).
In NameWrapper._canFusesBeBurned, condition should be different:
jefflau (ENS) commented:
Arachnid (ENS) disagreed with severity and commented:
LSDan (judge) decreased severity to Medium and commented:
