Submitted by rajatbeladiya, also found by __141345__, _Adam, 0x29A, 0xNineDec, alan724, Amithuddar, asutorufos, Aussie_Battlers, berndartmueller, c3phas, cccz, Ch_301, cryptphi, csanuragjain, Dravee, durianSausage, fatherOfBlocks, GimelSec, hake, hyh, IllIllI, Jujic, Limbooo, pashov, RedOneN, Ruhum, scaraven, TomJ, and zzzitron
ETHRegistrarController.sol#L183-L185
ETHRegistrarController.sol#L204
transfer() forwards 2300 gas only, which may not be enough in future if the recipient is a contract and gas costs change. it could break existing contracts functionality.
.transfer or .send method, only 2300 gas will be forwarded to fallback function. Specifically, the SLOAD instruction, will go from costing 200 gas to 800 gas.
If any smart contract has a functionality of register ens and it has fallback function which is making some state change in contract on ether receive, it could use more than 2300 gas and revert every transaction.
For reference, check out:
Use .call insted .transfer
jefflau (ENS) confirmed, but disagreed with severity and commented:
LSDan (judge) decreased severity to Medium and commented:
Arachnid (ENS) commented:
LSDan (judge) commented:
Arachnid (ENS) commented:
