Submitted by berndartmueller, also found by 0xsanson, hubble, Lambda, Metatron, and swit
Fees are expected to be paid whenever an option is exercised (as per the function comment on L235).
If a put option is exercised, the exerciser receives the strike price (initially deposited by the short position holder) denominated in order.baseAsset.
If a call option is exercised, the exerciser sends the strike price to Putty and the short position holder is able to withdraw the strike amount.
However, the current protocol implementation is missing to deduct fees for exercised put options. Put options are free of any fees.
The protocol fee is correctly charged for exercised calls:
PuttyV2.withdraw
Contrary, put options are free of any fees:
PuttyV2.sol#L450-L451
Charge fees also for exercised put options.
outdoteth (Putty Finance) commented:
HickupHH3 (judge) commented:
outdoteth (Putty Finance) confirmed and resolved:
hyh (warden) reviewed mitigation:
