Submitted by unforgiven
SponsorVault.sol#L187-L220
When code swaps tokens it should specify slippage but in reimburseLiquidityFees() code contract calls tokenExchange.swapExactIn() without slippage and its possible to perform sandwich attack and make contract to swap on bad exchange rates and there is MEV.
This is reimburseLiquidityFees() code in SponserVault:
As you can see there is no slippage defined when calling swapExactIn() can that swap could happen in any exchange rate. its possible to perform sandwich attack and do large swap before and after the transaction and make users lose funds. and its also MEV opportunity.
VIM
Specify slippage when calling swap tokens.
jakekidd (Connext) acknowledged and commented:
0xleastwood (judge) commented:
For this contest, 57 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by BowTiedWardens received the top score from the judge.
The following wardens also submitted reports: 0x1f8b, cccz, unforgiven, cryptphi, xiaoming90, WatchPug, 0xf15ers, bardamu, cmichel, oyc_109, IllIllI, JMukesh, joestakey, Chom, hansfriese, SmartSek, sorrynotsorry, catchup, Jujic, kenta, Ruhum, 0xNineDec, simon135, TerrierLover, 0x52, 0xNazgul, asutorufos, ch13fd357r0y3r, k, Lambda, robee, shenwilly, SooYa, tintin, TomJ, _Adam, 0xkatana, auditor0517, cloudjunky, csanuragjain, defsec, ElKu, fatherOfBlocks, Funen, hyh, jayjonah8, sach1r0, 0x29A, 0xmint, c3phas, Kaiziron, MiloTruck, obtarian, slywaters, Waze, and zzzitron.
