Submitted by 0xmint
BridgeFacet.sol#L346
BridgeFacet.sol#L812
Affected  functions(that rely on swapAsset()) are:
AssetLogic.sol#L193
AssetLogic.sol#L159
swapAsset() facilitates two swaps, either using the internal or external pool. But if an internal pool exists, a swap will be unsuccessful because the call to
s.swapStorages[_canonicalId].swapInternal() takes two incorrect arguments (due to an incorrect ordering, this seemed to be an oversight, acknowledged by #Layne) :
AssetLogic.sol#L278-L279
Based on the above mentioned code , the arguments would be incorrectly changed to :
SwapUtils.sol#L744-L745
The condition checked here:
SwapUtils.sol#L750
will never be true as the msg.sender would never own the quantity of tokens being swapped from since its the wrong token.
jakekidd (Connext) confirmed and resolved:
0xleastwood (judge) commented:
