Submitted by oyc_109
There is potential to call initialize() on AccountantDelegate.sol more than once because the require statement only checks if the state variables != address(0)
https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Accountant/AccountantDelegate.sol#L23-L25
If initialize() was called the first with these parameters as address(0x0), then initialize can be called again
https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Accountant/AccountantDelegate.sol#L17
The require statement should also check if the parameters != zero address, similar to the check performed in TreasuryDelegate.sol
https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Treasury/TreasuryDelegate.sol#L23
Or use openzepplen initializable.
nivasan1 (Canto) acknowledged and commented:
Alex the Entreprenerd (judge) commented:
