Submitted by rotcivegaf
Broke the EIP 712, and the delegateBySig function.
In the build of the DOMAIN TYPEHASH the string version is forgotten, but the delegateBySig function, build the domainSeparator with the string version.
Some contract or dapp/backend could building the DOMAIN_TYPEHASH with rigth struct(include the version) and try to use the delegateBySig function but this function will revert in the L1378 with the message "VotingEscrow::delegateBySig: invalid signature" because the expect DOMAIN_TYPEHASH in the VotingEscrow.sol contract was built with the wrong struct.
Acording the EIP 712, in the Definition of domainSeparator:
Add string version, to the EIP712Domain string, L1106:
Build the domainSeparator L1362 in the constructor to save gas and clarify/clean code
pooltypes (Velodrome) disputed
Alex the Entreprenerd (judge) commented:
