Submitted by jonah1005, also found by berndartmueller, Picodes, IllIllI, sorrynotsorry, and WatchPug
GeneralVault.sol#L125
GeneralVault set a hardcoded slippage control of 99%. However, the underlying yield tokens price may go down.
If Luna/UST things happen again, users funds may get locked.
LidoVault.sol#L130-L137
Moreover, the withdrawal of the lidoVault takes a swap from the curve pool. 1 stEth worth 0.98 ETH at the time of writing.
The vault can not withdraw at the current market.
Given that users funds would be locked in the lidoVault, I consider this a high-risk issue.
1 stEth  = 0.98 Eth
LidoVault.sol#L130-L137
There are different ways to set the slippage.
The first one is to let users determine the maximum slippage theyre willing to take.
The protocol front-end should set the recommended value for them.
The second one is have a slippage control parameters thats set by the operator.
These are two common ways to deal with this issue. I prefer the first one.
The market may corrupt really fast before the operator takes action.
Its nothing fun watching the number go down while having no option.
sforman2000 (Sturdy) confirmed
iris112 (Sturdy) commented:
hickuphh3 (judge) commented:
