Submitted by Kulk0, also found by 0x1f8b, 0xDjango, BowTiedWardens, broccolirob, defsec, Dinddle, dirk_y, hyh, rajatbeladiya, Ruhum, throttle, and unforgiven
ForgottenRunesWarriorsMinter.sol#L257
In ForgottenRunesWarriorsMinter.teamSummon() the owner can mint unrestricted amount of NFTs. This is more of a design issue than an actual bug in my opinion.
If the private keys were compromised during the launch the attacker could mint almost all of the NFTs. Normally I wouldnt say this is an issue but from your documentation, I understand that you are not planning to use a multi-sig wallet for the owner of the contracts. I definitely dont want to say that you are incompetent and you cant store your private keys safely but private keys are getting compromised very often in this space.
Limit how many NFTs can the owner mint. So even if the private keys were compromised the attacker couldnt destroy the entire set by minting thousands of the NFTs to himself making the entire set worth nothing.
I also think this will help with the trust of the protocol since the buyers will know exactly how many NFTs can the Dev Team mint for themselves.
cryppadotta (Forgotten Runes) acknowledged and commented:
gzeon (judge) marked as Invalid and commented:
dmitriia (warden) commented:
gzeon (judge) reassessed as Medium severity and commented:
For this contest, 75 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by defsec received the top score from the judge.
The following wardens also submitted reports: reassor, IllIllI, hubble, rotcivegaf, hake, horsefacts, throttle, AuditsAreUS, berndartmueller, BowTiedWardens, hickuphh3, hyh, joestakey, robee, Ruhum, shung, sorrynotsorry, sseefried, leastwood, pedroais, TerrierLover, VAD37, WatchPug, 0xDjango, catchup, delfin454000, ilan, kebabsec, kenta, MaratCerby, p4st13r4, pauliax, rfa, shenwilly, tintin, 0x1f8b, 0x52, 0xf15ers, 0xkatana, 0xliumin, cccz, csanuragjain, dirk_y, eccentricexit, fatherOfBlocks, Funen, GimelSec, hansfriese, Hawkeye, kenzo, rajatbeladiya, teddav, TrungOre, unforgiven, z3s, 0v3rf10w, 0x4non, broccolirob, CertoraInc, Cr4ckM3, cryptphi, ellahi, Kulk0, M0ndoHEHE, m9800, marximimus, minhquanym, oyc_109, peritoflores, Picodes, plotchy, samruna, simon135, and gzeon.
