Submitted by pedroais, also found by AuditsAreUS, BowTiedWardens, defsec, GimelSec, gzeon, IllIllI, leastwood, and WatchPug
ForgottenRunesWarriorsMinter.sol#L564
ForgottenRunesWarriorsMinter.sol#L571
ForgottenRunesWarriorsMinter.sol#L557
ForgottenRunesWarriorsMinter.sol#L571
The price for the dutch auction could be altered.
I previously sent an issue about start time being settable more than once. This also happens for many other variables. Since they are many I will send them all in a single issue.
The following functions should only be called once to ensure trustlessness and integrity of the dutch auction:
setDaPriceCurveLength
setStartPrice
setLowestPrice
setDaDropInterval
The price in the dutch auction is computed by this formula:
uint256 dropPerStep = (startPrice - lowestPrice) /
(daPriceCurveLength / daDropInterval);
By making dapriceCurveLength or daDropInterval equal to 0 the owner could stop the auction. This could benefit the owner since the price lowers with time and everyone pays the final lower price. If the auction does well at the beginning the owner could stop the auction to stop the price from being lower. This works against the integrity of the dutch auction.
Also changing the Start Price or the Lowest price in the middle of the auction could allow the owner to manipulate the price.
To each of these setter functions add require (variable == 0) to ensure they are set once in a permanent way. Also, the Lowest price < startPrice should be required.
gzeon (judge) commented:
