Submitted by berndartmueller
If matchingEnabled in RubiconMarket is changed from false to true, all offers created while matchingEnabled = false can not be matched or canceled if matchingEnabled is toggled to true again. Only changing the value matchingEnabled back to false allows those offers to be used again.
Offers created while matchingEnabled = false do not populate _rank and _best. However, both variables are used in multiple functions isOfferSorted, _unsort, _hide which are used if matchingEnabled = true.
For example, canceling an offer that has been created when matchingEnabled = false and enabling matching again, will revert:
RubiconMarket.sol#L685-L691
Consider removing the functionality to toggle matchingEnabled or only allow changing matchingEnabled to false without changing the value back to true.
bghughes (Rubicon) disputed and commented:
HickupHH3 (judge) commented:
