Submitted by hickuphh3, also found by GimelSec, gzeon, and scaraven
https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/MerkleResistor.sol#L259
https://github.com/code-423n4/2022-05-factorydao/blob/db415804c06143d8af6880bc4cda7222e5463c0e/contracts/MerkleResistor.sol#L264
It is possible for coinsPerSecond to be zero. In these cases, the startTime calculation
will revert from division by zero, preventing initialization, and by extension, withdrawals of vested tokens.
We assume vesting time chosen is the maximum (tree.maxEndTime) so that totalCoins = maxTotalPayments. These examples showcase some possibilities for which the calculated coinsPerSecond can be zero.
Scale up coinsPerSecond by PRECISION, then scale down when executing withdrawals. While it isnt foolproof, the possibility of coinsPerSecond being zero is reduced significantly.
illuzen (FactoryDAO) confirmed, disagreed with severity and commented:
Justin Goro (judge) decreased severity to Medium and commented:
