Submitted by IllIllI, also found by Adam, 0x52, 0xf15ers, 0xsanson, berndartmueller, Bludya, BondiPestControl, catchup, crispymangoes, Czar102, eccentricexit, ellahi, GimelSec, hake, horsefacts, hubble, joestakey, Kumpa, pedroais, peritoflores, reassor, shenwilly, shung, smilingheretic, sseefried, and throttle_
Owner can steal the exercise cost which should have gone to the option seller
There are no restrictions on when the owner can set the feeRate:
https://github.com/code-423n4/2022-05-cally/blob/1849f9ee12434038aa80753266ce6a2f2b082c59/contracts/src/Cally.sol#L117-L121
By using a rate that consumes the exercise cost, the owner can steal Ether from the seller:
https://github.com/code-423n4/2022-05-cally/blob/1849f9ee12434038aa80753266ce6a2f2b082c59/contracts/src/Cally.sol#L282-L289
The owner can wait for a particularly large-value NFT, snipe that one option, then retire
Fix the fee rate per vault during vault creation
outdoteth (Cally) confirmed and resolved:
HardlyDifficult (judge) commented:
